Agility ticket

INT PR

Merge after B-20946, as this has work built off of code on that branch

B-20946 INT PR

B-20948 INT PR

Summary

The SSW Actual Obligations 100% GCC Calculation was wrong because it was using the estimated weight. I changed the calculation to use the Actual Weight (that comes from the weight tickets) up to the maximum weight entitlement or allowable weight, whichever is lessor.

Actual Weight for a PPM is calculated by function getActualWeight that does all of the work. This unction adds up the total weight for the weight tickets and returns its value. functionPPMCloseoutFetcher.GetActualWeight(ppmShipment) at pkg/services/ppm_closeout/ppm_closeout.go line 227

You can also see the actual weight on the MTO tab as a counselor. "Actual PPM Weight"

Is there anything you would like reviewers to give additional scrutiny?

this article explains more about the approach used.

Verification Steps for the Author

These are to be checked by the author.

• Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
• Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

• Has the branch been pulled in and checked out?
• Have the BL acceptance criteria been met for this change?
• Was the CircleCI build successful?
• Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

• Instructions for starting storybook
• Instructions for starting the MilMove application
• Instructions for running tests

How to test

1. Access office as a service counselor
2. Select a PPM Closeout move
3. while under Move Details Tab scroll down and select "Download AOA Paperwork (PDF)"
4. Once downloaded inspect the 100% GCC value under Actual Obligations section under the Entitlements & move summary
5. The value should be the actual weight up to the (entitlement weight or allowed weight) whichever is lessor. The value should also not include any Progear. For Example:

If:
Entitlement = 5000
TotalWeight = 7500
Actual Weight = 4000
Then 100% GCC should equal 4000lbs

If:
Entitlement = 5000
TotalWeight = 7500
Actual Weight = 6000
Then 100% GCC should equal 5000lbs

You can add weight tickets as a customer by going to a customer with a PPM Shipment and following step 6:

Frontend

• There are no aXe warnings for UI.
• This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
• There are no new console errors in the browser devtools.
• There are no new console errors in the test output.
• If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
• This change meets the standards for Section 508 compliance.

Backend

• Code follows the guidelines for Logging.
• The requirements listed in Querying the Database Safely have been satisfied.

Database

Any new migrations/schema changes:

• Follows our guidelines for Zero-Downtime Deploys.
• Have been communicated to #g-database.
• Secure migrations have been tested following the instructions in our docs.

Screenshots